Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] same_marker_velocity and docstrings scooted #687

Merged
merged 6 commits into from
Jun 1, 2023

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented May 25, 2023

some more docs


This change is Reviewable

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (d3764bb) 81.81% compared to head (cbd9e2e) 81.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   81.81%   81.83%   +0.01%     
==========================================
  Files         112      112              
  Lines       12953    12967      +14     
==========================================
+ Hits        10598    10612      +14     
  Misses       2355     2355              
Impacted Files Coverage Δ
bioptim/dynamics/configure_problem.py 90.92% <100.00%> (ø)
bioptim/limits/constraints.py 79.60% <100.00%> (+0.08%) ⬆️
bioptim/limits/objective_functions.py 92.22% <100.00%> (+0.04%) ⬆️
bioptim/limits/penalty.py 90.03% <100.00%> (+0.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ipuch Ipuch changed the title scoot doc [RTR] same_marker_velocity and docstrings scooted May 26, 2023
pariterre
pariterre previously approved these changes Jun 1, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre merged commit e67cf00 into pyomeca:master Jun 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants