Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] Ipopt options were problematic #709

Merged
merged 4 commits into from Jul 6, 2023
Merged

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Jul 6, 2023

fixing solver ipopt options methods. adressing #706 @EveCharbie


This change is Reviewable

fixing solver ipopt options methods.
@Ipuch Ipuch changed the title ipopt options were problematic [RTR] Ipopt options were problematic Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.35 🎉

Comparison is base (5d440e3) 80.95% compared to head (17dd4e0) 81.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   80.95%   81.30%   +0.35%     
==========================================
  Files         119      119              
  Lines       13571    13571              
==========================================
+ Hits        10986    11034      +48     
+ Misses       2585     2537      -48     
Impacted Files Coverage Δ
bioptim/interfaces/solver_options.py 84.21% <100.00%> (+10.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre changed the title [RTR] Ipopt options were problematic [RTM] Ipopt options were problematic Jul 6, 2023
@pariterre pariterre merged commit be06b78 into pyomeca:master Jul 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants