Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] Multimodel, I need animation and displaced the file for more convinience #761

Merged
merged 11 commits into from Sep 21, 2023

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Sep 18, 2023

This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage is 81.45% of modified lines.

Files Changed Coverage
bioptim/optimization/solution.py 0.00%
bioptim/interfaces/multi_biorbd_model.py 81.44%
bioptim/__init__.py 100.00%
bioptim/interfaces/biomodel.py 100.00%
bioptim/interfaces/biorbd_model.py 100.00%

📢 Thoughts on this report? Let us know!.

pariterre
pariterre previously approved these changes Sep 19, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre merged commit 8bd8b05 into pyomeca:master Sep 21, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants