Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM when tests pass] Refactor solution with classmethods #789

Merged
merged 10 commits into from Nov 2, 2023

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Nov 1, 2023

All Submissions:

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...examples/torque_driven_ocp/example_soft_contact.py 83.58% <100.00%> (ø)
bioptim/gui/plot.py 70.29% <100.00%> (ø)
bioptim/optimization/non_linear_program.py 90.90% <100.00%> (+0.05%) ⬆️
bioptim/optimization/optimal_control_program.py 85.95% <100.00%> (ø)
...ptim/optimization/receding_horizon_optimization.py 95.98% <100.00%> (ø)
bioptim/optimization/solution.py 79.17% <69.60%> (-0.06%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@Ipuch Ipuch changed the title Refactor solution with classmethods [RTR] Refactor solution with classmethods Nov 1, 2023
pariterre
pariterre previously approved these changes Nov 2, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)


bioptim/optimization/optimal_control_program.py line 2024 at r2 (raw file):

def concatenate_optimization_variables(

To be removed? Or to be put protected?

@Ipuch Ipuch dismissed pariterre’s stale review November 2, 2023 18:05

The merge-base changed after approval.

@pariterre pariterre changed the title [RTR] Refactor solution with classmethods Refactor solution with classmethods Nov 2, 2023
@pariterre pariterre changed the title Refactor solution with classmethods [RTM when tests pass] Refactor solution with classmethods Nov 2, 2023
Copy link
Collaborator Author

@Ipuch Ipuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @pariterre)


bioptim/optimization/optimal_control_program.py line 2024 at r2 (raw file):

Previously, pariterre (Pariterre) wrote…

To be removed? Or to be put protected?

Done.

@Ipuch Ipuch dismissed pariterre’s stale review November 2, 2023 18:37

The merge-base changed after approval.

pariterre
pariterre previously approved these changes Nov 2, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

@pariterre pariterre closed this Nov 2, 2023
@Ipuch Ipuch deleted the init_solution_2 branch November 2, 2023 18:38
@Ipuch Ipuch restored the init_solution_2 branch November 2, 2023 18:42
@pariterre pariterre reopened this Nov 2, 2023
@pariterre pariterre merged commit 3edb545 into pyomeca:master Nov 2, 2023
40 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants