New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTR] Mayer_TRACK_CONTACT_FORCES #797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Alpha2Shahiri)
bioptim/limits/objective_functions.py
line 379 at r1 (raw file):
MINIMIZE_COM_POSITION = (PenaltyFunctionAbstract.Functions.minimize_com_position,) MINIMIZE_COM_VELOCITY = (PenaltyFunctionAbstract.Functions.minimize_com_velocity,) MINIMIZE_CONTROL = (PenaltyFunctionAbstract.Functions.minimize_controls,)
Remove this line
bioptim/limits/objective_functions.py
line 396 at r1 (raw file):
SUPERIMPOSE_MARKERS = (PenaltyFunctionAbstract.Functions.superimpose_markers,) SUPERIMPOSE_MARKERS_VELOCITY = (PenaltyFunctionAbstract.Functions.superimpose_markers_velocity,) TRACK_CONTROL = (PenaltyFunctionAbstract.Functions.minimize_controls,)
Remove this
bioptim/limits/objective_functions.py
line 401 at r1 (raw file):
TRACK_MARKERS_ACCELERATION = (PenaltyFunctionAbstract.Functions.minimize_markers_acceleration,) TRACK_MARKERS_VELOCITY = (PenaltyFunctionAbstract.Functions.minimize_markers_velocity,) TRACK_CONTACT_FORCES = (PenaltyFunctionAbstract.Functions.minimize_contact_forces,)
Remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @pariterre)
bioptim/limits/objective_functions.py
line 379 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
Remove this line
Done
bioptim/limits/objective_functions.py
line 396 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
Remove this
Done
bioptim/limits/objective_functions.py
line 401 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
Remove this
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Alpha2Shahiri)
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*"
)?Changes to Core Features:
This change is