"Namespaced" public headers files

[SpaceIm]

public headers names are very common (Point.h, Frame.h, Parameter.h etc).
To properly live in a project with others dependencies, and avoid clashes, I would advice to add an intermediate folder (ezc3d for example ;) ), and update build scripts (and some #include because some of them take absolute path).

Obviously, it would be a breaking change in ezc3d interface...

[pariterre]

Hi @SpaceIm !
I've read the linked issue, but I am not sure what is better for you guys. Do you mean that the files should be included #include "ezc3d/SomeFile.h"? If so, I think it definitely makes sense and I will make the changes soon!

[madebr]

Hey @pariterre
At these lines:

ezc3d/CMakeLists.txt

Lines 100 to 102 in 7d40969

	target_include_directories(${PROJECT_NAME} INTERFACE
	$<INSTALL_INTERFACE:${${PROJECT_NAME}_INCLUDE_FOLDER}>
	)

You set the include directories of the installed target to include/ezc3d.

ezc3d/CMakeLists.txt

Line 84 in 7d40969

set(${PROJECT_NAME}_INCLUDE_FOLDER include/${PROJECT_NAME})

This means that including a subheader using #include <ezc3d/Point.h> is not possible.
I suggest also adding include:

target_include_directories(${PROJECT_NAME} INTERFACE
    $<INSTALL_INTERFACE:${${PROJECT_NAME}_INCLUDE_FOLDER}>
    $<INSTALL_INTERFACE:include>
)

[pariterre]

Considering that names are quite generic would not you suggest also to remove the first line? $<INSTALL_INTERFACE:${${PROJECT_NAME}_INCLUDE_FOLDER}>

[madebr]

@pariterre
That would change the interface to your users.
Run the following github search query
It shows that most of your users include the headers using a plain #include "ezc3d.h".
Removing $<INSTALL_INTERFACE:${${PROJECT_NAME}_INCLUDE_FOLDER}> would break this.

It's easy to fix, but annoying.

[pariterre]

@madebr
I tried with $<INSTALL_INTERFACE:${${PROJECT_NAME}_INCLUDE_FOLDER}>/.. so it adjust to whatever the folder is.
Does this PR #166 makes sense for you guys?

[madebr]

It does the trick to me.

[pariterre]

I am waiting for Travis to complete (actually start.. Don't know why it is so long lately...) and then I merge!

[pariterre]

It is merge, hopefully this works all fine!

[SpaceIm]

Yes it should work, but it doesn't solve potential clashes with headers from other libraries since ${${PROJECT_NAME}_INCLUDE_FOLDER} is still added to include dirs.

[pariterre]

Indeed
I feel that since I am the main programmer on most of the software that use ezc3d, I should actually fix this properly. That definitely would make sense.
In any case, thanks for your input!

[pariterre]

For posterity, I was about to change that, but it makes this complicated with the global includer. I've decided that unless someone else complaints about that specific issue, I will leave it as so

Thanks again!