Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numpy issue with windows #123

Merged
merged 1 commit into from Jun 13, 2021
Merged

Fix numpy issue with windows #123

merged 1 commit into from Jun 13, 2021

Conversation

romainmartinez
Copy link
Member

@romainmartinez romainmartinez commented Jun 13, 2021 •
edited

This PR fix an issue found in the windows CI reached during the installation process.

@coveralls
Copy link

coveralls commented Jun 13, 2021 •
edited

Pull Request Test Coverage Report for Build 933354104

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 483023975: 0.0%
Covered Lines: 654
Relevant Lines: 654
💛 - Coveralls

@romainmartinez
Copy link
Member Author

@pariterre, this is ready to be merged.

pariterre
pariterre approved these changes Jun 13, 2021
View reviewed changes
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pariterre pariterre merged commit 0ba3dfb into master Jun 13, 2021
@romainmartinez romainmartinez deleted the romainmartinez-patch-windows branch June 14, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pariterre pariterre pariterre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romainmartinez @coveralls @pariterre