FE: slowly refactor extractQualifiersFromAnnotations JetBrains#1

That code is convoluted, better take it slow to avoid accidentally breaking (or fixing) anything.
pyos · Aug 11, 2021 · cf8e66d · cf8e66d
1 parent ae16e38
commit cf8e66d
Showing 1 changed file with 22 additions and 18 deletions.
diff --git a/...escriptors.jvm/src/org/jetbrains/kotlin/load/java/typeEnhancement/signatureEnhancement.kt b/...escriptors.jvm/src/org/jetbrains/kotlin/load/java/typeEnhancement/signatureEnhancement.kt
@@ -274,6 +274,20 @@ private class SignatureParts(
                 composeAnnotations(typeContainer.annotations, typeOrBound.annotations)
             } else typeOrBound.annotations
 
+        val annotationsMutability = annotationTypeQualifierResolver.extractMutability(composedAnnotation)
+        val annotationsNullability = annotationTypeQualifierResolver.extractNullability(composedAnnotation) {
+            (this is LazyJavaAnnotationDescriptor && (isFreshlySupportedTypeUseAnnotation || typeParameterBounds) && !areImprovementsInStrictMode) ||
+                    (this is PossiblyExternalAnnotationDescriptor && isIdeExternalAnnotation)
+        }.takeUnless { type == null }
+
+        if (annotationsNullability != null) {
+            return JavaTypeQualifiers(
+                annotationsNullability.qualifier, annotationsMutability,
+                annotationsNullability.qualifier == NullabilityQualifier.NOT_NULL && typeOrBound.isTypeParameter(),
+                annotationsNullability.isForWarningOnly
+            )
+        }
+
         val defaultTypeQualifier = (
                 if (isHeadTypeConstructor)
                     containerContext.defaultTypeQualifiers?.get(containerApplicabilityType)
@@ -288,28 +302,18 @@ private class SignatureParts(
 
         val (nullabilityFromBoundsForTypeBasedOnTypeParameter, isTypeParameterWithNotNullableBounds) =
             typeOrBound.nullabilityInfoBoundsForTypeParameterUsage()
-
-        val annotationsNullability = annotationTypeQualifierResolver.extractNullability(composedAnnotation) {
-            (this is LazyJavaAnnotationDescriptor && (isFreshlySupportedTypeUseAnnotation || typeParameterBounds) && !areImprovementsInStrictMode) ||
-                    (this is PossiblyExternalAnnotationDescriptor && isIdeExternalAnnotation)
-        }.takeUnless { type == null }
-        val nullabilityInfo =
-            annotationsNullability
-                ?: computeNullabilityInfoInTheAbsenceOfExplicitAnnotation(
-                    nullabilityFromBoundsForTypeBasedOnTypeParameter,
-                    defaultTypeQualifier,
-                    typeParameterForArgument,
-                    type == null
-                )
+        val nullabilityInfo = computeNullabilityInfoInTheAbsenceOfExplicitAnnotation(
+            nullabilityFromBoundsForTypeBasedOnTypeParameter,
+            defaultTypeQualifier,
+            typeParameterForArgument,
+            type == null
+        )
 
         val isNotNullTypeParameter =
-            if (annotationsNullability != null)
-                annotationsNullability.qualifier == NullabilityQualifier.NOT_NULL
-            else
-                isTypeParameterWithNotNullableBounds || defaultTypeQualifier?.makesTypeParameterNotNull == true
+            isTypeParameterWithNotNullableBounds || defaultTypeQualifier?.makesTypeParameterNotNull == true
 
         return JavaTypeQualifiers(
-            nullabilityInfo?.qualifier, annotationTypeQualifierResolver.extractMutability(composedAnnotation),
+            nullabilityInfo?.qualifier, annotationsMutability,
             isNotNullTypeParameter = isNotNullTypeParameter && typeOrBound.isTypeParameter(),
             isNullabilityQualifierForWarning = nullabilityInfo?.isForWarningOnly == true
         )