Fix bug in user defined network detection #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately there is no sane option to check whether a docker network is user defined, but we need that information in order to decide whether we can carry over the ip addresses. This commit adds a try/except block that tries to set the ip addresses on the new container, and falls back to not setting them when an exception occurs. Signed-off-by: julian <dev@jneureuther.de>
dirtycajunrice
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to #195
Fixes #196
Unfortunately there is no sane option to check whether a docker network is user defined, but we need that information in order to decide whether we can carry over the ip addresses.
This commit adds a try/except block that tries to set the ip addresses on the new container, and falls back to not setting them when an exception occurs.
I'm not really satisfied by classifying the exception by comparing the message to a string (
'user specified IP address is supported only when connecting to networks with user configured subnets' in str(e)), but that's the only implementation that came to my mind.