Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Warning for label_enable not set while using labels_only #202

Merged

Conversation

larsderidder
Copy link

I spend a few minutes confused because I set labels_only to true, expecting labels to work. However, it required labels_enable to be set to true as well.

I don't see a scenario where setting labels_only but not enabling labels makes sense, so the update simply sets labels_enable to true if labels_only is true.

@dirtycajunrice
Copy link
Member

This was intentionally left as it was to allow "turning off" label_enable temporarily. I feel as though this is better suited in the wiki under the labels_only section. If you would like to add a logger.warning('labels_only enabled but not in use without label_enable') I see no issue with that. Thoughts?

@larsderidder
Copy link
Author

I see, that makes sense. What about setting label_enable to true only if it's omitted and labels_only is true? Setting it to false explicitly could still work, and we could then show the warning.

@dirtycajunrice
Copy link
Member

false/commented out is personal preference. its much easier (read lazier) to just comment out the env line in compose than to type false. so i see that backfiring ya know?

@dirtycajunrice
Copy link
Member

How we doing on this one

@larsderidder
Copy link
Author

Updated.

Copy link
Member

@dirtycajunrice dirtycajunrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@dirtycajunrice dirtycajunrice added the enhancement New feature or request label Feb 13, 2019
@dirtycajunrice dirtycajunrice changed the title Set labels enable if labels only is set Add Warning for label_enable not set while using labels_only Feb 13, 2019
@dirtycajunrice dirtycajunrice merged commit ba63149 into pyouroboros:develop Feb 13, 2019
dirtycajunrice added a commit that referenced this pull request Feb 13, 2019
@larsderidder larsderidder deleted the labels-only-enables-labels branch February 14, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants