Optimise dockerfile layers #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightvisi0n
force-pushed
the
feature_optimise-dockerfile
branch
2 times, most recently
from
6017d23
to
fe7aa2c
Compare
|
(Fixed some errors from flake 8) |
this results in: - faster builds during development - less changes to pull when updating the image from docker hub (6MiB <-> 40KiB) Signed-off-by: julian <dev@jneureuther.de>
nightvisi0n
force-pushed
the
feature_optimise-dockerfile
branch
from
fe7aa2c
to
35bbf8a
Compare
|
@dirtycajunrice I rebased the PR against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR changes the buildup of the Dockerfiles so that the ouroboros source code is only copied after all dependencies are installed.
This results in:
./pyouroboroschanges