Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move api client out of cli.py #38

Merged
merged 3 commits into from
Oct 27, 2018
Merged

Move api client out of cli.py #38

merged 3 commits into from
Oct 27, 2018

Conversation

tlkamp
Copy link
Contributor

@tlkamp tlkamp commented Oct 27, 2018

This PR moves api_client out of cli.py and instead creates an api_client in the main loop. Since cli.py no longer provides the api_client, the api_client is a now a function argument for functions that need a client. This makes mocking/testing significantly easier.

@codecov-io
Copy link

Codecov Report

Merging #38 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   96.45%   96.35%   -0.11%     
==========================================
  Files           7        7              
  Lines         141      137       -4     
==========================================
- Hits          136      132       -4     
  Misses          5        5
Impacted Files Coverage Δ
ouroboros/cli.py 100% <ø> (ø) ⬆️
ouroboros/main.py 90.47% <100%> (+0.23%) ⬆️
ouroboros/image.py 100% <100%> (ø) ⬆️
ouroboros/container.py 97.36% <100%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02dfd0...0600164. Read the comment docs.

@circa10a
Copy link
Member

Heck of a PR, very clean!

@circa10a circa10a merged commit 6b1b1ba into pyouroboros:master Oct 27, 2018
@tlkamp tlkamp deleted the move-api-client branch October 27, 2018 19:02
@dirtycajunrice dirtycajunrice added the enhancement New feature or request label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants