Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #79

Merged
merged 54 commits into from
Jan 12, 2019
Merged

Refactor #79

merged 54 commits into from
Jan 12, 2019

Conversation

dirtycajunrice
Copy link
Member

No description provided.

@circa10a circa10a requested a review from tlkamp January 10, 2019 13:25
@circa10a
Copy link
Member

@dirtycajunrice

Will take me a bit to run some of my own sanity tests against it, but an incredible contribution nonetheless. 💯

Flake8 reported these lint errors, also one unused import:

./ouroboros.py:70:77: E241 multiple spaces after ','
./ouroboros.py:74:89: E241 multiple spaces after ','
./ouroboros.py:78:87: E241 multiple spaces after ','
./ouroboros.py:82:87: E241 multiple spaces after ','
./ouroboros.py:86:87: E241 multiple spaces after ','
./pyouroboros/helpers.py:8:18: E241 multiple spaces after ':'
./pyouroboros/helpers.py:9:22: E241 multiple spaces after ':'
./pyouroboros/helpers.py:10:23: E241 multiple spaces after ':'
./pyouroboros/logger.py:9:37: E241 multiple spaces after ','
./pyouroboros/logger.py:9:51: E241 multiple spaces after ','
./pyouroboros/dockerclient.py:1:1: F401 'schedule' imported but unused

Did pep8 by itself not report these? (Trying to determine what tool to use going forward)

@circa10a circa10a merged commit 5fec8b5 into pyouroboros:master Jan 12, 2019
@dirtycajunrice dirtycajunrice added the enhancement New feature or request label Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants