Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep new release - 3.1.0? #149

Closed
ghenry opened this issue Nov 23, 2022 · 11 comments
Closed

Prep new release - 3.1.0? #149

ghenry opened this issue Nov 23, 2022 · 11 comments
Assignees
Labels
new release Discuss and prep a new release

Comments

@ghenry
Copy link
Collaborator

ghenry commented Nov 23, 2022

Hi @Pyozer

Should we prep a new release, say 3.1.0 listing any potential breaking changes due to all the merged PRs?

They all add new features however, so I think we'll be good. I'll run the example again to check though. I'm just waiting for #143 and #138 to get back to us, but they aren't blockers.

Thanks,
Gavin.

@ghenry ghenry added the new release Discuss and prep a new release label Nov 23, 2022
@ghenry
Copy link
Collaborator Author

ghenry commented Nov 23, 2022

Example app running fine on Android 13 sim and physical device. Will test on iOS sim and physical tomorrow.

@Pyozer
Copy link
Owner

Pyozer commented Nov 23, 2022

Hi @ghenry,

Thank you very much, it's really great everything you have done for the project !
I will made the release tomorrow ;)

@ghenry
Copy link
Collaborator Author

ghenry commented Nov 23, 2022

My pleasure! I hope it's taken a bit of pressure off of you now and you can relax a bit.

@ghenry
Copy link
Collaborator Author

ghenry commented Nov 24, 2022

Runs fine on latest Xcode and macOS on a MacBook Air M2 (apple silicon) - 9dde9e2

Can't test a real device with the example as it tries to register the app id to my Apple dev account, so will report any issues when I test in my own project.

Thanks!

@ghenry
Copy link
Collaborator Author

ghenry commented Nov 25, 2022

We have tests now too :-)

@ghenry
Copy link
Collaborator Author

ghenry commented Nov 26, 2022

Morning,

Would you like to show me how to do all the pub.dev tasks, or I can Google and then I just need perms.

Then I can automate a release when we make a new tag.

Thanks.

@Pyozer
Copy link
Owner

Pyozer commented Nov 26, 2022

Hello, sorry I finally didn't find the time to do the release, but I don't forget.
I will try today, I should be able by late afternoon.
Yes why not give you the rights to publish, I'll see that.

Thanks again for all the hard work!

@ghenry
Copy link
Collaborator Author

ghenry commented Nov 26, 2022

No worries. Look forward to continuing to help out!

@Pyozer
Copy link
Owner

Pyozer commented Nov 26, 2022

New release 3.1.0 published 🎉🎉
Thanks again !

I looked into adding you as a publisher, can you give me your email address? I've accepted you on LinkedIn, you can send it to me by message ;)

@ghenry
Copy link
Collaborator Author

ghenry commented Nov 26, 2022

Congratulations!

@ghenry
Copy link
Collaborator Author

ghenry commented Nov 26, 2022

I've done a release and created a v3.1.0 tag https://github.com/Pyozer/introduction_screen/releases/tag/v3.1.0

Closing now. Nice team work!

@ghenry ghenry closed this as completed Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new release Discuss and prep a new release
Projects
None yet
Development

No branches or pull requests

2 participants