-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auditwheel should warn on invalid versions, e.g. dev
#108
Comments
I bet this is an incompatibility with the latest version of wheel. Try
install wheel 0.31.1. Does that work?
|
Nah. I'm already pinned at 0.31.1. Nothing works with latest version.
…On Thu, Oct 18, 2018, 2:29 AM Matthew Brett ***@***.***> wrote:
I bet this is an incompatibility with the latest version of wheel. Try
install wheel 0.31.1. Does that work?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#108 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE84pHShJ7IHuyfquj9Yf39G0lDMLx4Jks5umEoAgaJpZM4Xs0dO>
.
|
Ah - sorry. Yes, I think what is happening is that auditwheel is
using wheel code to determine the parts of the file name, according to
this spec:
https://www.python.org/dev/peps/pep-0427/#file-name-convention
It's doing this so it can work out which bit is the platform tag, to
replace it with manylinux1. If your filename does not conform to that
spec, then it's going to fail, in the way you've seen, because the
regular expression doesn't match.
|
I see, it doesn't seem to specify a particular format for version but I can
understand the constraint. Do you think it would be valuable to catch this
case and throw a more intelligible error at the user?
…On Thu, Oct 18, 2018, 5:52 AM Matthew Brett ***@***.***> wrote:
Ah - sorry. Yes, I think what is happening is that auditwheel is
using wheel code to determine the parts of the file name, according to
this spec:
https://www.python.org/dev/peps/pep-0427/#file-name-convention
It's doing this so it can work out which bit is the platform tag, to
replace it with manylinux1. If your filename does not conform to that
spec, then it's going to fail, in the way you've seen, because the
regular expression doesn't match.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#108 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE84pJwCnvhywCKOaphyisjRkj3YgkREks5umHmegaJpZM4Xs0dO>
.
|
Yes, a better error would be good. Would you consider doing a PR to put one in? I guess it's just a check for None, in parsed_fname, maybe in the |
Btw version numbers are supposed to follow the format given in PEP 440: https://www.python.org/dev/peps/pep-0440/ |
dev
dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dev
was just a special case, from what I can tell if thex.y.z
kind of string isn't present I'll get:Is this known? Intended? I can get still get away by doing something like
0.0.1-dev
but still.The text was updated successfully, but these errors were encountered: