Ensure policies in policy.json are compliant with PEP600
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes 2 non existing symbols from manylinux1 i686 policy and removes ncurses librairies from manylinux1 whitelist.
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
+ Coverage 89.03% 90.63% +1.60%
==========================================
Files 20 20
Lines 1058 1079 +21
Branches 226 232 +6
==========================================
+ Hits 942 978 +36
+ Misses 69 57 -12
+ Partials 47 44 -3
Continue to review full report at Codecov.
|
Merged
|
Failure on TravisCI ppc64le is unrelated to the PR. |
lkollar
reviewed
Feb 28, 2021
auditwheel/policy/__init__.py
Outdated
| if policy['name'] == 'linux': | ||
| continue | ||
| if not lib_whitelist.issubset(set(policy['lib_whitelist'])): | ||
| raise ValueError('Invalid "policy.json" file') |
There was a problem hiding this comment.
How about making the string more explicit on what's wrong with the policy check? That could make it easier to diagnose the issue when editing the JSON.
There was a problem hiding this comment.
I added more information and tests for that. Is that better now ?
mayeut
force-pushed
the
enforce-pep600-policies
branch
from
5aee132
to
cffc994
Compare
mayeut
force-pushed
the
enforce-pep600-policies
branch
from
cffc994
to
b452f14
Compare
lkollar
approved these changes
Feb 28, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes 2 non existing symbols from manylinux1 i686 policy and removes ncurses librairies from manylinux1 whitelist.
Now that PEP600 supersedes previous manylinux PEPs, it should be enforced:
Fix #286