Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manylinux_2_27 policy #300

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Add manylinux_2_27 policy #300

merged 1 commit into from
Mar 28, 2021

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Mar 27, 2021

This policy is based on symbols from ubuntu 18.04 with GLIBCXX_3.4.25 symbols removed (introduced in gcc-8 and incompatible with Photon 3 distro based on glibc 2.28).

As long as gcc-7 is used on ubuntu 18.04, using this distro should lead to manylinux_2_27 compliant wheels.

Symbol compatibility analysis done using https://github.com/mayeut/pep600_compliance data.

Fix #299

This policy is based on symbols from ubuntu 18.04 with GLIBCXX_3.4.25 symbols removed (introduced in gcc-8 and incompatible with Photon 3 distro based on glibc 2.28).

As long as gcc-7 is used on ubuntu 18.04, using this distro should lead to manylinux_2_27 compliant wheels.

Symbol compatibility analysis done using https://github.com/mayeut/pep600_compliance data.

Fix pypa#299
@mayeut mayeut mentioned this pull request Mar 27, 2021
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #300 (e474199) into master (bcf8083) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   91.24%   91.24%           
=======================================
  Files          20       20           
  Lines        1097     1097           
  Branches      237      237           
=======================================
  Hits         1001     1001           
  Misses         54       54           
  Partials       42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcf8083...e474199. Read the comment docs.

@mayeut mayeut merged commit 7d4090b into pypa:master Mar 28, 2021
@mayeut mayeut deleted the manylinux_2_27 branch March 28, 2021 08:24
@mayeut mayeut mentioned this pull request Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add manylinux_2_27 policy
2 participants