Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't installs self in tox deps #319

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Don't installs self in tox deps #319

merged 1 commit into from
Aug 16, 2021

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Aug 13, 2021

Tox already does that by default.

In Fedora, when we build RPM packages,
we use a tox plugin that installs the test requirements from RPMs.
It does not know how to install the package we are building.

Tox already does that by default.

In Fedora, when we build RPM packages,
we use a tox plugin that installs the test requirements from RPMs.
It does not know how to install the package we are building.
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #319 (520e5fb) into master (b2ea792) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          20       20           
  Lines        1102     1102           
  Branches      237      237           
=======================================
  Hits         1006     1006           
  Misses         54       54           
  Partials       42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ea792...520e5fb. Read the comment docs.

@mayeut mayeut merged commit 9d47670 into pypa:master Aug 16, 2021
@hroncok hroncok deleted the patch-1 branch August 16, 2021 14:08
@mayeut mayeut mentioned this pull request Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants