Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run black #329

Merged
merged 1 commit into from
Sep 2, 2021
Merged

chore: run black #329

merged 1 commit into from
Sep 2, 2021

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Aug 28, 2021

Reformat the code base with black.
It provides a known look & feel compared to other pypa projects (e.g. build, cibuildwheel, packaging, pip, ...)

@mayeut mayeut requested a review from lkollar August 28, 2021 15:22
@mayeut mayeut mentioned this pull request Aug 28, 2021
@codecov
Copy link

codecov bot commented Aug 28, 2021

Codecov Report

Merging #329 (35676b1) into master (a2c6557) will not change coverage.
The diff coverage is 88.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files          23       23           
  Lines        1204     1204           
  Branches      254      254           
=======================================
  Hits         1076     1076           
  Misses         78       78           
  Partials       50       50           
Impacted Files Coverage Δ
auditwheel/__main__.py 0.00% <0.00%> (ø)
auditwheel/genericpkgctx.py 50.00% <0.00%> (ø)
auditwheel/condatools.py 91.66% <50.00%> (ø)
auditwheel/main_show.py 70.58% <73.68%> (ø)
auditwheel/policy/versioned_symbols.py 92.30% <83.33%> (ø)
auditwheel/repair.py 85.59% <84.37%> (ø)
auditwheel/lddtree.py 87.17% <87.30%> (ø)
auditwheel/tools.py 92.59% <87.50%> (ø)
auditwheel/policy/__init__.py 82.72% <88.23%> (ø)
auditwheel/main_addtag.py 86.84% <90.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c6557...35676b1. Read the comment docs.

Copy link
Contributor

@lkollar lkollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also use a .git-blame-ignore-revs file to ignore the commit in git blame? See https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame.

Copy link
Contributor

@lkollar lkollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add black to the lint rule in tox.

@mayeut
Copy link
Member Author

mayeut commented Sep 2, 2021

We should also add black to the lint rule in tox.

This will be handled by #331

@mayeut
Copy link
Member Author

mayeut commented Sep 2, 2021

Can we also use a .git-blame-ignore-revs file to ignore the commit in git blame?

Depending how it'll be merged, the commit might change. better do this after it's merged.

@mayeut mayeut merged commit aa52a60 into pypa:master Sep 2, 2021
@mayeut mayeut deleted the black branch September 2, 2021 20:42
mayeut added a commit to mayeut/auditwheel that referenced this pull request Sep 2, 2021
This file is used as a convention for commits to be ignored by bulk code changes.
commit aa52a60 is such a commit (conversion to black code style).
see pypa#329 (review) /  https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants