Remove PURGE call on StalePage #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This call now 401s so there is no benefit of calling it - Also spams logs with noise - So lets remove before more people open issues Test: - See tests pass - Remove assertion of request being sent on StalePage as we no longer do ... That is this PRs purpose Fixes #1334
Codecov ReportBase: 83.48% // Head: 83.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1335 +/- ##
==========================================
+ Coverage 83.48% 83.49% +0.01%
==========================================
Files 31 31
Lines 4220 4212 -8
Branches 620 619 -1
==========================================
- Hits 3523 3517 -6
+ Misses 521 519 -2
Partials 176 176
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ichard26
approved these changes
Jan 3, 2023
Co-authored-by: Richard Si <sichard26@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test:
Fixes #1334