Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest and version pinning clash #1601

Merged
merged 7 commits into from
Nov 12, 2023

Conversation

miicha
Copy link
Contributor

@miicha miicha commented Nov 7, 2023

Make sure that pinned versions defined with project_requirements_pinned plugins are downloaded by disabling additional filter if version (range) is specified.

implements #1599

@miicha miicha force-pushed the latest-and-version-pinning-clash branch from 303c323 to c903a67 Compare November 7, 2023 22:12
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ee09a76) 83.53% compared to head (8a7f3d4) 83.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1601      +/-   ##
==========================================
+ Coverage   83.53%   83.55%   +0.01%     
==========================================
  Files          31       31              
  Lines        4307     4324      +17     
  Branches      774      780       +6     
==========================================
+ Hits         3598     3613      +15     
- Misses        523      524       +1     
- Partials      186      187       +1     
Files Coverage Δ
src/bandersnatch/filter.py 96.70% <50.00%> (-1.05%) ⬇️
src/bandersnatch/package.py 93.54% <94.73%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miicha
Copy link
Contributor Author

miicha commented Nov 7, 2023

pre-commit.ci autofix

Copy link
Contributor

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for making this. Makes sense to me.

src/bandersnatch_filter_plugins/allowlist_name.py Outdated Show resolved Hide resolved
src/bandersnatch/tests/plugins/test_allowlist_name.py Outdated Show resolved Hide resolved
src/bandersnatch/tests/plugins/test_allowlist_name.py Outdated Show resolved Hide resolved
@cooperlees cooperlees merged commit 79e3568 into pypa:main Nov 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants