Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugins less noisey and more stateful #197

Merged
merged 3 commits into from
Apr 13, 2019
Merged

Conversation

cooperlees
Copy link
Contributor

  • Only initialize if the plugin is enabled in config
  • Move all plugins to store their loaded state as a static / class variable

Fixes #195 #193 #147

- Only initialize if the plugin is enabled in config
- Move all plugins to store their loaded state as a static / class variable
@cooperlees cooperlees added the enhancement New feature or request label Apr 12, 2019
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #197 into master will decrease coverage by 0.05%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   81.53%   81.47%   -0.06%     
==========================================
  Files           9        9              
  Lines         926      934       +8     
  Branches      138      141       +3     
==========================================
+ Hits          755      761       +6     
- Misses        145      147       +2     
  Partials       26       26
Impacted Files Coverage Δ
src/bandersnatch/filter.py 98.21% <100%> (+0.17%) ⬆️
src/bandersnatch/mirror.py 93.01% <20%> (-0.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435b1f2...58d81ee. Read the comment docs.

- Remove uneeded debug output for whitelist_project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.3.0 Platform Filter Plugin Noise when not enabled
1 participant