Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Windows 3.9.9 tests #413

Closed
layday opened this issue Dec 11, 2021 · 2 comments · Fixed by #420
Closed

Failing Windows 3.9.9 tests #413

layday opened this issue Dec 11, 2021 · 2 comments · Fixed by #420

Comments

@layday
Copy link
Member

layday commented Dec 11, 2021

Can someone with Windows experience take a look at why the Windows 3.9.9 tests are failing? Some context might be found at actions/setup-python#267.

@layday layday changed the title Fail Failing Windows 3.9.9 tests Dec 11, 2021
@layday
Copy link
Member Author

layday commented Dec 24, 2021

As predicted the 3.10 tests are also failing with the release of 3.10.1.

layday added a commit to layday/build that referenced this issue Dec 24, 2021
After python/cpython@6811fda
the venv module produces spurious warnings for venv paths which contain
DOS-encoded parts e.g. "USER~1" in "C:\Users\USER~1".
`tempfile.gettempdir()` returns legacy paths like these for
user temp dirs.

MRE:

    python -c "import tempfile
    import venv

    venv.create(tempfile.mkdtemp())"

    Actual environment location may have moved due to redirects, links or junctions.
    Requested location: "C:\Users\RUNNER~1\AppData\Local\Temp\tmpfoobar\Scripts\python.exe"
    Actual location:    "C:\Users\runneradmin\AppData\Local\Temp\tmpfoobar\Scripts\python.exe"

Closes pypa#413.
@layday
Copy link
Member Author

layday commented Dec 24, 2021

layday added a commit that referenced this issue Jan 5, 2022
* env: prevent warning from being emitted on venv creation

After python/cpython@6811fda
the venv module produces spurious warnings for venv paths which contain
DOS-encoded parts e.g. "USER~1" in "C:\Users\USER~1".
`tempfile.gettempdir()` returns legacy paths like these for
user temp dirs.

MRE:

    python -c "import tempfile
    import venv

    venv.create(tempfile.mkdtemp())"

    Actual environment location may have moved due to redirects, links or junctions.
    Requested location: "C:\Users\RUNNER~1\AppData\Local\Temp\tmpfoobar\Scripts\python.exe"
    Actual location:    "C:\Users\runneradmin\AppData\Local\Temp\tmpfoobar\Scripts\python.exe"

Closes #413.

* tests: fix logging line nos

* fixup! env: prevent warning from being emitted on venv creation

* tests: fix line nos, again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant