Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main: avoid cost of importing virtualenv if not using it #636

Merged
merged 1 commit into from Jul 3, 2023
Merged

main: avoid cost of importing virtualenv if not using it #636

merged 1 commit into from Jul 3, 2023

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jul 3, 2023

Fix #510. If a user is using -n, skip the cost of importing virtualenv.

@henryiii
fix: avoid importing virtualenv if not using it
a603ba3 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii changed the title fix: avoid importing virtualenv if not using it main: avoid cost of importing virtualenv if not using it Jul 3, 2023
@henryiii henryiii merged commit 7a4b1bf into pypa:main Jul 3, 2023
62 checks passed
@henryiii henryiii deleted the henryiii/fix/virtualenvimport branch July 3, 2023 22:52
@KOLANICH
Copy link
Contributor

KOLANICH commented Jul 4, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layday layday layday approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

@gaborbernat gaborbernat Awaiting requested review from gaborbernat gaborbernat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't import virtualenv if it is not actually needed.
3 participants
@henryiii @KOLANICH @layday