Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--config-settings is passed as --config-setting #1429

Closed
Schamper opened this issue Mar 10, 2023 · 2 comments · Fixed by #1430
Closed

--config-settings is passed as --config-setting #1429

Schamper opened this issue Mar 10, 2023 · 2 comments · Fixed by #1430

Comments

@Schamper
Copy link

Description

Whenever I try to use the feature to pass --config-settings (either through environment variable or pyproject.toml), I am met with a no such option: --config-setting error in the logs.

A cursory look at the pip documentation seems to suggest the argument name actually is --config-settings:
https://pip.pypa.io/en/stable/cli/pip_wheel/#cmdoption-config-settings

It looks like the options that should be passed as --config-settings are actually being passed as --config-setting (missing the s):

return [f"--config-setting={setting}" for setting in config_settings_list]

Build log

No response

CI config

No response

@henryiii
Copy link
Contributor

henryiii commented Mar 10, 2023

Build and pip differ here. So it (should be) conditional. (If you use the build backend, I expect it works currently). The next version of pip will support -C, just like build.

@joerick
Copy link
Contributor

joerick commented Mar 11, 2023

Fixed in v2.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants