Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][infra] Set up a pypa.io subdomain? #1688

Closed
webknjaz opened this issue Dec 6, 2023 · 15 comments · Fixed by #1775
Closed

[docs][infra] Set up a pypa.io subdomain? #1688

webknjaz opened this issue Dec 6, 2023 · 15 comments · Fixed by #1775

Comments

@webknjaz
Copy link
Member

webknjaz commented Dec 6, 2023

Description

$sbj. It's essentially the same as pypa/pipx#1058.
Any objections?

Build log

No response

CI config

No response

@joerick
Copy link
Contributor

joerick commented Jan 26, 2024

This would be nice. But, is there a way to make all the links to cibuildwheel.readthedocs.io redirect to the new domain? There are a lot of links to that domain. I'm not sure I'd like to make the change unless we can be confident that URLs will properly redirect. e.g. if a link sent a user to https://cibuildwheel.readthedocs.io/en/stable/options/#before-build, they end up at https://cibuildwheel.pypa.io/en/stable/options/#before-build

@webknjaz
Copy link
Member Author

Yes, that's how it works out of the box, zero config needed.

@webknjaz
Copy link
Member Author

@ewdurbin hey Ee, could you make another CNAME for this RTD project too, plz?

@henryiii
Copy link
Contributor

You can see this working for build, which did this recently.

@joerick
Copy link
Contributor

joerick commented Jan 27, 2024

Nice, yeah I just tested it and the redirect was perfect, even including the URL fragment (i guess this is standard browser behaviour, TIL).

https://pypa-build.readthedocs.io/en/stable/installation.html#compatibility

@ewdurbin
Copy link
Member

@ewdurbin hey Ee, could you make another CNAME for this RTD project too, plz?

Yes. Please add my user on readthedocs.org for the project first. (This is primarily so that DNS/cert/etc settings can be managed in the future by PSF infra).

@henryiii
Copy link
Contributor

@joerick is the only one listed on rtd, so he’ll need to do it.

@henryiii
Copy link
Contributor

Did we not do that with build?

@joerick
Copy link
Contributor

joerick commented Jan 29, 2024

Thanks @ewdurbin ! just sent you the invite to the RtD project.

edit: also invited @henryiii for bus-factor purposes

@ewdurbin
Copy link
Member

CNAME and domain configuration added.

@webknjaz
Copy link
Member Author

@henryiii @joerick RTD config update pending?

@joerick
Copy link
Contributor

joerick commented Feb 26, 2024

I totally forgot about this, thanks for the reminder! I'll take a look tomorrow. It will probably need some code/docs edits too so might require some planning to sync it up with a release.

@webknjaz
Copy link
Member Author

It will probably need some code/docs edits

Not really. Those shouldn't be blockers since the redirects will work for the old links just fine.

@joerick
Copy link
Contributor

joerick commented Mar 4, 2024

Those shouldn't be blockers since the redirects will work for the old links just fine.

Sure, not blockers but I don't see any reason to rush, I'd rather keep things neat and make the change all at once with a release.

@joerick
Copy link
Contributor

joerick commented Mar 11, 2024

It's done! Btw, thanks to whoever changed over the sidebar URL :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants