Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache_tag in default build_platlib dir #133

Merged
merged 1 commit into from Apr 10, 2022

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Apr 9, 2022

Use sys.implementation.cache_tag instead of Python version to create
the default directory for build_platlib. This guarantees that
the directories used by CPython and PyPy are distinct. Prior to
the change, both CPython and PyPy would use e.g. lib.linux-x86_64-3.9.
With the change, they are going to use lib.linux-x86_64-cpython39
and lib.linux-x86_64-pypy39 respectively.

Use `sys.implementation.cache_tag` instead of Python version to create
the default directory for `build_platlib`.  This guarantees that
the directories used by CPython and PyPy are distinct.  Prior to
the change, both CPython and PyPy would use e.g. `lib.linux-x86_64-3.9`.
With the change, they are going to use `lib.linux-x86_64-cpython39`
and `lib.linux-x86_64-pypy39` respectively.
@kmod
Copy link

kmod commented Apr 25, 2022

Hello, I'd like to advocate for a different name for these directories. There is a bit of a convention of using sysconfig.get_config_var("VERSION") for this purpose instead of sys.implementation.cache_tag, so these new cache directories will be named differently than most of the ecosystem expects. For example

These directory names are used for significantly more than caching, so I believe VERSION is a bit more appropriate. See #107 for a bit of rationale and my proposed code change.

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 29, 2022
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 29, 2022
Also backports a fix for tests [1]

See: https://wiki.archlinux.org/index.php?title=Python_package_guidelines&type=revision&diff=743435&oldid=742361
See: pypa/distutils#133

[1] brianolson/cbor_py#19



git-svn-id: file:///srv/repos/svn-community/svn@1285262 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 29, 2022
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 29, 2022
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 29, 2022
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 29, 2022
Also backports a fix for tests [1]

See: https://wiki.archlinux.org/index.php?title=Python_package_guidelines&type=revision&diff=743435&oldid=742361
See: pypa/distutils#133

[1] brianolson/cbor_py#19

git-svn-id: file:///srv/repos/svn-community/svn@1285262 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 29, 2022
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Aug 29, 2022
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Oct 28, 2022
See: pypa/distutils#133

git-svn-id: file:///srv/repos/svn-community/svn@1338429 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Oct 28, 2022
See: pypa/distutils#133


git-svn-id: file:///srv/repos/svn-community/svn@1338429 9fca08f4-af9d-4005-b8df-a31f2cc04f65
krivenko added a commit to krivenko/pycommute that referenced this pull request Mar 3, 2023
…and newer

These setuptools versions use a slightly different naming scheme for the
compiled module build directory.

Further details:

[1] pypa/distutils#133
[2] pypa/setuptools@f4d3174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants