Add custom pypirc support #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Aug 28, 2021
This patch removes the default value from the pypirc argument so None can be used as a sentinel value. In case the provided value does not exist an error is raised. Otherwise, if no value is provided "~/.pypirc" is used as default.
takluyver
reviewed
Sep 14, 2021
takluyver
reviewed
Sep 14, 2021
takluyver
reviewed
Sep 29, 2021
| temp_file.close() | ||
| yield temp_file.name | ||
| finally: | ||
| os.unlink(temp_file.name) |
There was a problem hiding this comment.
Pytest has a handy shortcut for this - if you use a tmp_path fixture in a test, it creates a temporary directory, you can write whatever you want there, and it will all be cleaned up when the test runs. Docs here
I'm happy with this, the fixture is just a neat thing to know about. 🙂
There was a problem hiding this comment.
Thanks! Good to learn about that :)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for handling a custom path for the
.pypircfile. Previously the file was assumed to always be in~/.pypirc, which can be an issue depending on the build environment that is being used as stated in #426.The path can be passed through the
--pypircargument, as such:A unit test was added to ensure the parsing is correctly done when the custom path is specified.