Add --use-vcs and --no-use-vcs flags for build commands #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 from me. The docs changes look good, and the plan for switching the default seems reasonable. I can't really comment on the code so I'll leave that for others. One thing that I'd like which is missing, is a clear description of what files will be put in the wheel. Is it just "the stuff in the sdist that's from the package directory"? Having it explicitly stated would avoid any guessing. |
|
@Carreau @pradyunsg I'm planning to merge this in a couple more days, so if you're not happy with this direction, now's the time to say so. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion on #522, this adds an option to not use the VCS to get the list of files to include in the sdist. So
flit build --no-use-vcsis equivalent topython -m buildwith flit_core as a backend. The idea is that in a future version (4.0?), this will become the default, and you will need to use--use-vcsto explicitly choose the sdist-files-from-vcs behaviour.I've also tried to improve the documentation about what gets included in the sdist by default.