Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hm... Should we make the target dir customizable? #10

Closed
webknjaz opened this issue Aug 23, 2019 · 2 comments · Fixed by #19
Closed

Hm... Should we make the target dir customizable? #10

webknjaz opened this issue Aug 23, 2019 · 2 comments · Fixed by #19
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest 🎃🐱‍💻 DO's annual PR encouragement

Comments

@webknjaz
Copy link
Member

Hm... Should we make the target dir customizable?

Originally posted by @webknjaz in https://github.com/pypa/gh-action-pypi-publish/pull/7/files

@breznak
Copy link

breznak commented Sep 26, 2019

Do you mean a custom path to dist/ ? If so, I agree.

I have dist/ generated elsewhere, so before this step I need to run an extra step: mv my/dist /dist.

Would be nice to have an optional arg distPath=/dist/

 uses: pypa/gh-action-pypi-publish@master
  with:
    user: __token__
    password: ${{ secrets.test_pypi_password }}
    dist: "my/path/dist"

@webknjaz
Copy link
Member Author

@breznak do you want to contribute this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest 🎃🐱‍💻 DO's annual PR encouragement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants