Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in hatchling 1.12.0: some optional config_settings became mandatory #691

Closed
musicinmybrain opened this issue Dec 31, 2022 · 4 comments · Fixed by #693
Closed

Regression in hatchling 1.12.0: some optional config_settings became mandatory #691

musicinmybrain opened this issue Dec 31, 2022 · 4 comments · Fixed by #693

Comments

@musicinmybrain
Copy link
Contributor

musicinmybrain commented Dec 31, 2022 •
edited

When type annotations were added to backend/src/hatchling/build.py in 7b9c12d, several functions with a config_settings=None parameter lost the default value, making config_settings mandatory:

  • get_requires_for_build_editable
  • build_editable
  • prepare_metadata_for_build_wheel
  • prepare_metadata_for_build_editable

The same thing happened to get_requires_for_build_editable in backend/src/hatchling/ouroboros.py.

This breaks Fedora Linux’s use of the prepare_metadata_for_build_wheel hook (#128) to generate dependencies when building RPMs from Python packages that use hatchling, which has worked since #466.

I think this change was an accident.
@musicinmybrain musicinmybrain mentioned this issue Dec 31, 2022
Merged
musicinmybrain added a commit to musicinmybrain/hatch that referenced this issue Dec 31, 2022
@musicinmybrain
Restore missing default for config_settings
35df7eb 
Fixes pypa#691
@ofek
Copy link
Sponsor Collaborator

ofek commented Dec 31, 2022

Oh darn sorry about that

@musicinmybrain
Copy link
Contributor Author

Oh darn sorry about that

No worries! This regression is an easy fix, and the improvements in this release are really nice. Thanks for taking a look at it.

@ofek ofek closed this as completed in #693 Dec 31, 2022
ofek added a commit that referenced this issue Dec 31, 2022
@musicinmybrain @ofek
Restore missing default for config_settings (#693)
a122f0c 
* Restore missing default for config_settings

Fixes #691

* fix

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
@ofek
Copy link
Sponsor Collaborator

ofek commented Dec 31, 2022

I actually just introduced some scripts that make it easier to release, I will release it in a few moments 🙂

@ofek
Copy link
Sponsor Collaborator

ofek commented Dec 31, 2022

https://github.com/pypa/hatch/releases/tag/hatchling-v1.12.1

Thanks for the report and the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore missing default for config_settings musicinmybrain/hatch
2 participants
@musicinmybrain @ofek