Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra in pyproject.toml dependencies creates invalid Metadata #801

Closed
bnavigator opened this issue Mar 30, 2023 · 2 comments
Closed

Extra in pyproject.toml dependencies creates invalid Metadata #801

bnavigator opened this issue Mar 30, 2023 · 2 comments

Comments

@bnavigator
Copy link

jupyter_events' pyproject.toml has:

dependencies = [
    "jsonschema[format-nongpl,format_nongpl]>=3.2.0",

This is a valid PEP631/PEP508 entry. (Although its use is questionable)

Hatchling produces an invalid line in jupyter_events-0.6.3.dist-info/METADATA:

Requires-Dist: jsonschema[format-nongpl]>=3.2.0

This is not a valid string according to https://packaging.python.org/en/latest/specifications/core-metadata/#requires-dist-multiple-use which references the Name: tag.

@bnavigator bnavigator changed the title Multiple extras in pyproject.toml dependencies creates invalid Metadata Extra in pyproject.toml dependencies creates invalid Metadata Mar 30, 2023
@ofek
Copy link
Sponsor Collaborator

ofek commented Mar 30, 2023

I'm almost positive that is valid and the error lies with that RPM script, for example take a look at the following and then look inside the wheel:

@bnavigator
Copy link
Author

You're right, I confused the extra from jsonschema with the extra requirement marker.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Apr 3, 2023
https://build.opensuse.org/request/show/1075683
by user bnavigator + dimstar_suse
- Work around gh#rpm-software-management/rpmlint#1043
  * This produces false positives for python-missing-require and
    python-lefover-require but at least it does not crash rpmlint
  * See also gh#pypa/hatch#801, gh#jupyter/jupyter_events#70 (forwarded request 1075682 from bnavigator)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants