Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name .pth file so it loads first #828

Merged
merged 4 commits into from
Jun 3, 2023
Merged

Name .pth file so it loads first #828

merged 4 commits into from
Jun 3, 2023

Conversation

rmorshea
Copy link
Contributor

@rmorshea rmorshea commented Apr 18, 2023

Originally discussed in: #827 (reply in thread)

Users adding their own .pth files likely need to be loaded after the one inserted by hatchling. The only way to do this is by naming it such that the hatchling .pth file will come first alphabetically. One reasonable way to do this is to name the file with a preceding . character.

Users adding their own .pth files likely need to be loaded after the one inserted by hatchling. The only way to do this is by naming it so the hatchling .pth file comes first alphabetically.
@ofek ofek marked this pull request as ready for review June 3, 2023 14:23
@ofek ofek merged commit 2c91b57 into pypa:master Jun 3, 2023
28 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 3, 2023
* Name .pth file so it loads first

Users adding their own .pth files likely need to be loaded after the one inserted by hatchling. The only way to do this is by naming it so the hatchling .pth file comes first alphabetically.

* update

* add history entry

---------

Co-authored-by: Ofek Lev <ofekmeister@gmail.com> 2c91b57
@ofek
Copy link
Sponsor Collaborator

ofek commented Jun 3, 2023

Thanks!

@rmorshea
Copy link
Contributor Author

rmorshea commented Jun 3, 2023

No, thank you for getting this over the finish line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants