Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct RECORD file using csv.writer #118

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

frostming
Copy link
Contributor

To correctly quote paths in the record entry.

Fix #117

@pradyunsg pradyunsg changed the title Consturct RECORD file using csv.writer Construct RECORD file using csv.writer Apr 1, 2022
@Hnasar
Copy link

Hnasar commented Apr 1, 2022

The API isn't documented, but I'm not sure if it's used anywhere. I considered if this should instead issue a deprecation warning and keep the old function also, but it looks like this project doesn't mind slight breaking API changes (https://installer.readthedocs.io/en/latest/changelog/).

Edit: I see that these methods aren't listed in the public api in __all__, so it's fine.

So, this looks good to me! Thanks for investigating!

@frostming
Copy link
Contributor Author

ping @pradyunsg , may I get a review for this PR? thanks.

@pradyunsg pradyunsg merged commit 591e7a3 into pypa:main Jun 20, 2022
@pradyunsg
Copy link
Member

I'll cut a release with this over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RECORD file is not encoded correctly if the path contains commas
3 participants