Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the launcher executables fetching script #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented May 29, 2023

Closes #159

@pradyunsg pradyunsg enabled auto-merge (rebase) May 29, 2023 20:15
@pradyunsg
Copy link
Member Author

sigh The script no longer works.

This now reports more information, checks the HTTP status and prints
the size of the downloaded artifacts.
@pradyunsg pradyunsg disabled auto-merge May 29, 2023 20:40
@pradyunsg pradyunsg changed the title Update the launcher executables for Windows Update the launcher executables fetching script May 29, 2023
@pradyunsg
Copy link
Member Author

Whelp, looks like the executables on bitbucket weren't updated when the ones in distlib were updated. :/

@Secrus
Copy link
Member

Secrus commented Jun 4, 2023

Whelp, looks like the executables on bitbucket weren't updated when the ones in distlib were updated. :/

if I understand it correctly, the executables are built from the files in the repo. maybe we could build them ourselves using GH Actions runner?

@pradyunsg
Copy link
Member Author

pradyunsg commented Jun 19, 2023

maybe we could build them ourselves using GH Actions runner?

Yes, though I'm inclined to have bit-by-bit compatibility with stuff that's used in other places at the moment -- i.e. pull in copies from distlib release files instead. The caveat is that they're not the exact same set of files, so we'll need to review what we're supporting on Windows and match that compatibility with distlib/pip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the simple_launcher script wrappers
2 participants