Fix entrypoints management #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Jun 21, 2021
uranusjr
reviewed
Jun 21, 2021
src/installer/utils.py
Outdated
| @@ -190,6 +190,9 @@ def parse_entrypoints(text): | |||
|
|
|||
| # Borrowed from https://github.com/python/importlib_metadata/blob/v3.4.0/importlib_metadata/__init__.py#L90 # noqa | |||
There was a problem hiding this comment.
Is this comment still up-to-date @pradyunsg? The linked target is entirely different from the code below.
There was a problem hiding this comment.
Yea, this is out of date. Let’s drop it.
@sdispater could you make this change in this PR?
There was a problem hiding this comment.
Actually, nvm. Let’s do that in a follow up.
There was a problem hiding this comment.
@pradyunsg I did it anyway :-)
pradyunsg
approved these changes
Jun 23, 2021
2 tasks
|
Hi, when will this fix be released? I am planning to adopt |
|
Ah buggery. I forgot about that. I’ll do if over the coming weekend but if I don’t, please file a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently trying to integrate
installerinto Poetry and things are mostly good but there were issues with how the entrypoints were managed. More specifically:installerwas looking for aentry-points.txtfile while the actual file isentry_points.txt).parse_entrypoints()function only parses script entry points.