Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discussion of package formats, expanding "Wheel vs Egg" discussion #1397

Merged
merged 2 commits into from Apr 3, 2024

Conversation

jeanas
Copy link
Contributor

@jeanas jeanas commented Nov 15, 2023

@jeanas
Copy link
Contributor Author

jeanas commented Nov 15, 2023

CI had a spurious failure:

(      contribute: line   77) broken    https://weblate.org/ - HTTPSConnectionPool(host='weblate.org', port=443): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f8653733950>: Failed to establish a new connection: [Errno 101] Network is unreachable'))

Can it be retried?

@jeanas
Copy link
Contributor Author

jeanas commented Dec 10, 2023

I have updated this PR with latest main and made some minor fixes.

Review would be appreciated.

@jeanas
Copy link
Contributor Author

jeanas commented Dec 19, 2023

Fixed the merge conflict.

Review would still be appreciated 馃檪

Copy link
Contributor

@sinoroc sinoroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Some comments/nitpicks, but they should not block getting this merged

source/glossary.rst Show resolved Hide resolved
source/discussions/package-formats.rst Show resolved Hide resolved
source/discussions/package-formats.rst Show resolved Hide resolved
source/discussions/package-formats.rst Show resolved Hide resolved
@chrysle chrysle added this pull request to the merge queue Apr 3, 2024
Merged via the queue into pypa:main with commit 091e45c Apr 3, 2024
5 checks passed
@chrysle
Copy link
Contributor

chrysle commented Apr 3, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants