Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #701: Note pipenv project maintenance problems #715

Conversation

ncoghlan
Copy link
Member

  • set public deadline for tutorial removal if the pipenv release doesn't happen
  • emphasise poetry more as an option for library developers (and developers
    of applications that can be distributed as libraries)
  • update GitHub URL for poetry project

* set public deadline for tutorial removal if the pipenv release doesn't happen
* emphasise poetry more as an option for library developers (and developers
  of applications that can be distributed as libraries)
* update GitHub URL for poetry project
@ncoghlan ncoghlan requested a review from pfmoore April 10, 2020 04:27
Copy link
Sponsor Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ncoghlan, this looks great to me. I'll give others a chance to review before merging.

@pfmoore
Copy link
Member

pfmoore commented Apr 10, 2020

This looks OK to me.

Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change that I'd like, but I'm willing to approve either way as an interim clarification.

should also work on Python 2.7.
Developers of Python libraries, or of applications that support distribution
as Python libraries, should also consider the
`poetry <https://github.com/python-poetry/poetry>`_ project as a possible dependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a possible" -> "an alternative"

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this!

@ncoghlan ncoghlan merged commit 06902b5 into pypa:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants