move back to setuptools #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFY00
force-pushed
the
setuptools
branch
2 times, most recently
from
7dc9d94
to
57d700b
Compare
Closes pypa#363 Signed-off-by: Filipe Laíns <lains@riseup.net>
|
Does this only revert the PR that switched to Flit? Because this is not exactly what I’d expect if packaging switches to setuptools afresh in 2020. |
|
Basically yeah, only a few minor differences. I kept It's not a clean revert because the same commit also switched to pypa/build and @brettcannon wanted to keep that. |
brettcannon
approved these changes
Dec 4, 2020
|
It kept what I cared about, so I'm fine with taking the PR as-is. Thanks, @FFY00 ! |
|
Who's cutting the release? ;) https://github.com/pypa/packaging/blob/master/docs/development/release-process.rst |
|
I can do it Friday if no one else has time before then. |
|
Release 20.8 is out! |
openstack-mirroring
pushed a commit
to openstack/requirements
that referenced
this pull request
Dec 14, 2020
These versions dropped setup.py from the release tarball, breaking installation on older systems like CentOS. This affects ironic-python-agent-builder since it uses CentOS 8 by default. The breaking change has been reverted in pypa/packaging#367 Change-Id: Idb9e0a70728108b13fc097a74244226a676c97b3
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Dec 14, 2020
* Update requirements from branch 'master'
to 42e95166ffe584a722697048c6a674be03caad02
- Merge "Exclude packaging 20.5-20.7"
- Exclude packaging 20.5-20.7
These versions dropped setup.py from the release tarball, breaking
installation on older systems like CentOS. This affects
ironic-python-agent-builder since it uses CentOS 8 by default.
The breaking change has been reverted in
pypa/packaging#367
Change-Id: Idb9e0a70728108b13fc097a74244226a676c97b3
vishwin
added a commit
to vishwin/py-packaging
that referenced
this pull request
Apr 11, 2022
flit_core and installer are now mature enough to bootstrap themselves. Needed to enable a setuptools-free bootstrap environment and avoid circular dependencies. This reverts commit 14ad352. Signed-off-by: Charlie Li <vishwin@FreeBSD.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #363
Signed-off-by: Filipe Laíns lains@riseup.net