Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Token class in _tokenizer for pretty-printing. #621

Closed
wants to merge 1 commit into from

Conversation

KOLANICH
Copy link

@KOLANICH KOLANICH commented Dec 2, 2022

Now it behaves like a @dataclass.

(I don't really use a real @dataclass because it is not present in every version of Python I wanna support in my software dependent on this package).

@brettcannon
Copy link
Member

What's the specific purpose for this? Is this leaking out to users in some way and leading to subpar error messages?

@KOLANICH
Copy link
Author

KOLANICH commented Dec 3, 2022

It just simplifies debugging, so it's nice to have it, rather than not to have it and introduce temporarily for fixing every bug in the parser (and I guess a lot of them yet to be found).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants