Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip_audit/dependency_source: match candidate names against project #249

Merged
merged 7 commits into from Mar 28, 2022
Merged

pip_audit/dependency_source: match candidate names against project #249

merged 7 commits into from Mar 28, 2022

Conversation

woodruffw
Copy link
Member

See: pypa/packaging#527.

Fixes #248.

@woodruffw woodruffw added the component:dep-sources Dependency sources label Mar 28, 2022
@woodruffw woodruffw self-assigned this Mar 28, 2022
di
di reviewed Mar 28, 2022
View reviewed changes
Copy link
Sponsor Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add a test?

@woodruffw
Copy link
Member Author

LGTM, could you add a test?

Yep, was going to add one and remove the draft status 🙂

tetsuo-cpp
tetsuo-cpp approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw marked this pull request as ready for review March 28, 2022 17:42
@woodruffw woodruffw mentioned this pull request Mar 28, 2022
Closed
@woodruffw
Copy link
Member Author

Lint CI is broken because of a backwards-incompatible bump in click, pulled in via black: psf/black#2964

@woodruffw woodruffw requested a review from di March 28, 2022 18:07
@woodruffw woodruffw merged commit cf8951b into main Mar 28, 2022
@woodruffw woodruffw deleted the ww/discard-candidates-with-bad-names branch March 28, 2022 18:11
This was referenced Mar 28, 2022
Closed
Open
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 20, 2022
py-pip-audit: update to 2.1.1.
603b496 
## [2.1.1] - 2022-03-29

### Fixed

* Dependency sources: A bug caused by ambiguous parses of source distribution
  files was fixed ([#249](pypa/pip-audit#249))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetsuo-cpp tetsuo-cpp tetsuo-cpp approved these changes

@di di Awaiting requested review from di

Assignees

@woodruffw woodruffw

Labels
component:dep-sources Dependency sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip-audit not auditing the same package versions as pip installs.
3 participants
@woodruffw @di @tetsuo-cpp