Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject: constrain urllib3 #617

Merged
merged 3 commits into from
May 23, 2023
Merged

pyproject: constrain urllib3 #617

merged 3 commits into from
May 23, 2023

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented May 22, 2023 •
edited
Loading

This should not be merged.

This is just to evaluate the feasibility of a fork + determine whether anything else explodes.

See #616.

xrefs:

@woodruffw
pyproject: temporarily add my fork
3ec0668 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw added the dependencies Pull requests that update a dependency file label May 22, 2023
@woodruffw woodruffw self-assigned this May 22, 2023
@woodruffw
pyproject: don't use my fork
20cbaa5 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw changed the title [DNM] pyproject: temporarily add my fork pyproject: constrain urllib3 May 22, 2023
@woodruffw
Copy link
Member Author

@behnazh-w would you be able to give the changes in this branch a try? They resolve the crash for me (as well as the vulnerable dependency), but end-user testing is always appreciated 🙂

@woodruffw woodruffw requested review from tetsuo-cpp and di May 22, 2023 23:42
@woodruffw woodruffw marked this pull request as ready for review May 22, 2023 23:42
@woodruffw
CHANGELOG: record changes
0bdbc78 
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw mentioned this pull request May 22, 2023
Closed
@woodruffw woodruffw merged commit f9a00e0 into main May 23, 2023
7 checks passed
@woodruffw woodruffw deleted the ww/cachecontrol-fork branch May 23, 2023 00:08
@woodruffw woodruffw mentioned this pull request May 23, 2023
Merged
@behnazh-w
Copy link

@behnazh-w would you be able to give the changes in this branch a try? They resolve the crash for me (as well as the vulnerable dependency), but end-user testing is always appreciated slightly_smiling_face

Thanks for the quick fix. It all works well now 👍

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 28, 2023
py-pip_audit: update to 2.5.6.
7ef9ed0 
## [2.5.6]

### Fixed

* Fixed a crash caused by incompatible dependency changes
  ([#617](pypa/pip-audit#617))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@di di di approved these changes

@tetsuo-cpp tetsuo-cpp Awaiting requested review from tetsuo-cpp

Assignees

@woodruffw woodruffw

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woodruffw @behnazh-w @di