New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging does not expect 'extra' in marker (need vendor upgrade) #11191
Comments
This looks like a duplicate of #9643 |
|
You can pass {"extra": ""} to the evaluate call for your experimentation, which will let you move forward with that. @uranusjr I don't think we need a tracking issue for doing a vendoring upgrade. If you're in agreement, please feel free to close this out. :) |
Sure if you also remember to release packaging before the pip release 🙂 That’s the part I’m less sure about. |
Ouch, but fair. 😝 |
It doesn't look like packaging will get released for the 22.3 release, so I'm moving this to the 23.0 milestone. |
Description
Hi, I've been doing some hacks on pip recently, like taking extra requirements into account when
checking_install_conflicts
.I have rewritten the
method
ofpkg_resources.Distribution
, and every time I get the dependency, I will return the extra mim requirements.Here are the sample code:
I got this error during
check_install_conflicts
:The reason for the above error is that this code does not consider that the marker of the requirement obtained from METADATA may contain extras. Is this behavior a bug?
A sample METADTA that contains Requires-Dist:
Expected behavior
The requirement parsed from METADATA should consider the invalid situation of the marker?
For example, in src/pip/_internal/operations/check.py#L78 we can handle the invalid marker?
pip version
22.1.2
Python version
3.7
OS
ubuntu
How to Reproduce
See above
Output
see above
Code of Conduct
The text was updated successfully, but these errors were encountered: