Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support for self-referential extras #11296

Open
1 task done
ofek opened this issue Jul 24, 2022 · 3 comments
Open
1 task done

Document support for self-referential extras #11296

ofek opened this issue Jul 24, 2022 · 3 comments
Labels
C: tests Testing and related things good first issue A good item for first time contributors to work on state: awaiting PR Feature discussed, PR is needed type: docs Documentation related

Comments

@ofek
Copy link
Sponsor Contributor

ofek commented Jul 24, 2022

What's the problem this feature will solve?

This (coupled with maybe a new explicit test) will provide a guarantee to users that the following use case is supported:

[project]
name = "pkg"

[project.optional-dependencies]
all = ["pkg[a]", "pkg[b]"]
a = ["..."]
b = ["..."]

Describe the solution you'd like

Add a note in docs + a new test that explicitly checks this

Alternative Solutions

N/A

Additional context

@ichard26 found that this has been supported since 21.2 (tested by @henryiii) #10393 (comment)

Code of Conduct

@ofek ofek added S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Jul 24, 2022
@sbidoul sbidoul added state: awaiting PR Feature discussed, PR is needed type: docs Documentation related and removed state: awaiting PR Feature discussed, PR is needed S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Jul 25, 2022
@sbidoul
Copy link
Member

sbidoul commented Jul 25, 2022

I marked this as awaiting PR. I'd say a having adding a test is important if we document it.

@Bobronium

This comment was marked as off-topic.

@pradyunsg

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: tests Testing and related things good first issue A good item for first time contributors to work on state: awaiting PR Feature discussed, PR is needed type: docs Documentation related
Projects
None yet
Development

No branches or pull requests

5 participants