Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement much lazier lazy_wheel from conda_package_streaming #11447

Open
1 task done
dholth opened this issue Sep 14, 2022 · 2 comments · May be fixed by #12208
Open
1 task done

Implement much lazier lazy_wheel from conda_package_streaming #11447

dholth opened this issue Sep 14, 2022 · 2 comments · May be fixed by #12208
Labels
state: awaiting PR Feature discussed, PR is needed type: feature request Request for a new feature

Comments

@dholth
Copy link
Member

dholth commented Sep 14, 2022

What's the problem this feature will solve?

pip's lazy wheel makes far too many requests. There's a lazy_wheel fork that does the same work, without a wasted HEAD request, and guarantees success in 2 or 3 requests total. This makes a huge difference when latency is high.

https://github.com/conda-incubator/conda-package-streaming/blob/main/conda_package_streaming/lazy_wheel.py

Describe the solution you'd like

Re-integrate https://github.com/conda-incubator/conda-package-streaming/blob/main/conda_package_streaming/lazy_wheel.py into pip.

Alternative Solutions

No

Additional context

I wrote an early prototype of lazy_wheel

Code of Conduct

@dholth dholth added S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Sep 14, 2022
@pradyunsg
Copy link
Member

Please feel welcome to file a PR for this! :)

@pradyunsg pradyunsg added state: awaiting PR Feature discussed, PR is needed and removed S: needs triage Issues/PRs that need to be triaged labels Sep 14, 2022
@dholth
Copy link
Member Author

dholth commented Oct 3, 2022

See #11481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: awaiting PR Feature discussed, PR is needed type: feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants