Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a sdist and a pure py package exist, try to build sdist first #11818

Open
1 task done
Marco-Sulla opened this issue Feb 26, 2023 · 0 comments
Open
1 task done

If a sdist and a pure py package exist, try to build sdist first #11818

Marco-Sulla opened this issue Feb 26, 2023 · 0 comments
Labels
S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature

Comments

@Marco-Sulla
Copy link

What's the problem this feature will solve?

Currently, if a module have a pure py wheel published on Pypi and your architecture is not present in the prebuilt packages, pip installs the pure python wheel, even if on Pypi is present an sdist package.

Describe the solution you'd like

I suggest to make pip try to build first from sdist, and if it fails, install the pure py package if present.

Alternative Solutions

Current workaround is to make the C extension optional and remove the pure python package.

This is problematic, since it requires an additional effort for module testers. Furthermore, if the C extension fails to compile, the produced wheel is not named as a pure python one.

Additional context

PS: I'm a maintainer of a C extension. I had to change my code and use the workaround.

Code of Conduct

@Marco-Sulla Marco-Sulla added S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant