Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make rejection message for count 8 slightly different #12040

Merged
merged 3 commits into from May 21, 2023
Merged

make rejection message for count 8 slightly different #12040

merged 3 commits into from May 21, 2023

Conversation

stonebig
Copy link
Contributor

No description provided.

pfmoore
pfmoore approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick - I'd prefer starting with "pip is still looking..." rather than adding "quite", but I'm not that bothered either way.

Obviously, if there's any tests that rely on the exact wording (CI will pick this up if there are) these will need changing too.

@stonebig
Copy link
Contributor Author

changing to your liking the test naturally goes better
image

@sbidoul sbidoul merged commit 5cc3114 into pypa:main May 21, 2023
25 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stonebig @pfmoore @sbidoul