Filter out yanked links from available versions error message

[ddelange]

Fixes #11745

[uranusjr]

I wonder if this would introduce confusion from the other direction, i.e. pip must have a bug to not find a version that’s listed on PyPI. It may be a good idea to still show the yanked versions, either separately or annotated.

[ddelange]

@uranusjr I added a conditional logger.critical mentioning yanked versions if any

[uranusjr]

Maybe we can compare len(versions) and len(cands) and skip building this list if they match (indicating there’re no yanked versions at all)

[uranusjr]

Also I kind of wonder if the yanked version can be info instead. That’s just minor and subjective though.

[ddelange]

if I understood @pfmoore correctly, a version can be in both lists simultaneously if only some of the links for this version are yanked.

nothing to worry about for PyPI, but maybe this can be encountered elsewhere in the wild?

[uranusjr]

Good point. I’ll accept this as-is and someone else can worry about optimisation later.

[ddelange]

An equivalent single-lookup variation:

is_yanked = {True: set(), False: set()}
for c in cands:
    is_yanked[c.link.is_yanked if c.link else False].add(c.version)

versions = sorted(is_yanked[False])
yanked_versions = sorted(is_yanked[True])

How about that?

[ddelange]

Hi @uranusjr @pfmoore 👋

I pushed the snippet above. Anything else from my side?

[ddelange]

@sbidoul the same reasoning from #12224 (comment) would apply here

[sbidoul]

We should sort the versions, then convert to str for the sorting to be accurate.

[ddelange]

great catch! could you have a look again?

[sbidoul]

This dict feels a little bit awkward to me. I'd have done sets and a good old if. It might be a matter of personal preference though.

[ddelange]

agreed, removed 👍