Remove the pip3.x entrypoint from the pip wheel #12536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pip3.x entrypoint in the pip wheel was misleading, because the pip wheel works for any python 3 version. Pip continues to special-case itself to generate that version specific entry point when it installs itself.
pfmoore
approved these changes
Feb 23, 2024
|
Thanks for the ping, i'll adjust uv! |
sinoroc
reviewed
Feb 23, 2024
There was a problem hiding this comment.
I think we can remove it. I wanted to do it in another PR in case anyone has comments about that: #12537.
pradyunsg
approved these changes
Feb 24, 2024
konstin
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 26, 2024
Update #1918 to handle pypa/pip#12536, where pip removed their python minor entrypoints. Closes #1593.
konstin
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 26, 2024
Update #1918 to handle pypa/pip#12536, where pip removed their python minor entrypoints. Closes #1593.
konstin
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 28, 2024
Update #1918 to handle pypa/pip#12536, where pip removed their python minor entrypoints. Closes #1593.
konstin
added a commit
to astral-sh/uv
that referenced
this pull request
Mar 1, 2024
Update #1918 to handle pypa/pip#12536, where pip removed their python minor entrypoint. The pip test is semi-functional since it builds pip from source instead of using a wheel with the wrong entrypoint, we have to update it when this pip version has a release. Closes #1593.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a pip3.x entrypoint in the py3-none-any pip wheel is incorrect.
Pip continues to special-case itself to generate that version specific entry point when it installs itself, so having it in the wheel is useless and arguably a remnant of
setup.py installtimes.Related: #3164, #8010, pypa/packaging.python.org#1505
I can imagine relatively
far fetchedniche workflows that could be disturbed by this change, but I tend to think correctness should prevail.