Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP0426 [*] support #2997

Closed
brantlk opened this issue Jul 30, 2015 · 2 comments
Closed

PEP0426 [*] support #2997

brantlk opened this issue Jul 30, 2015 · 2 comments
Labels
auto-locked Outdated issues that have been locked by automation

Comments

@brantlk
Copy link

brantlk commented Jul 30, 2015

According to pep 0426, looks like I should be able to do pip install ComfyChair[*] to install all the extras defined for ComfyChair, but this isn't working and raises and exception instead. Also, I should be able to do pip install .[*] to install all the extras defined for the current package.

$ .tox/py27/bin/pip install ".[ldap]"

WORKS!

but these 2 fail:

$ .tox/py27/bin/pip install "keystone[*]"

or

$ .tox/py27/bin/pip install ".[*]"

with the following output:

Exception:
Traceback (most recent call last):
  File "/opt/stack/keystone/.tox/py27/local/lib/python2.7/site-packages/pip/basecommand.py", line 223, in main
    status = self.run(options, args)
  File "/opt/stack/keystone/.tox/py27/local/lib/python2.7/site-packages/pip/commands/install.py", line 270, in run
    wheel_cache
  File "/opt/stack/keystone/.tox/py27/local/lib/python2.7/site-packages/pip/basecommand.py", line 275, in populate_requirement_set
    wheel_cache=wheel_cache
  File "/opt/stack/keystone/.tox/py27/local/lib/python2.7/site-packages/pip/req/req_install.py", line 216, in from_line
    extras).extras
  File "/opt/stack/keystone/.tox/py27/local/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2980, in parse
    reqs = list(parse_requirements(s))
  File "/opt/stack/keystone/.tox/py27/local/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2920, in parse_requirements
    DISTRO, CBRACKET, line, p, (1,), "'extra' name"
  File "/opt/stack/keystone/.tox/py27/local/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py", line 2889, in scan_list
    raise RequirementParseError(msg, line, "at", line[p:])
RequirementParseError: Expected 'extra' name in __placeholder__[*] at *]

For the record:

$ .tox/py27/bin/pip --version
pip 7.1.0 from /opt/stack/keystone/.tox/py27/local/lib/python2.7/site-packages (python 2.7)

In keystone we have a tox.ini with a py27 testenv that has deps = .[ldap] and I'd like to change it to .[*] so that we don't have to keep the extras in sync with tox.ini.

@dstufft
Copy link
Member

dstufft commented Aug 2, 2015

PEP 426 isn't accepted yet (though some parts of it are in defacto use and the particular syntax of using * to mean "all extras" hasn't yet been implemented.

@dstufft
Copy link
Member

dstufft commented Mar 22, 2017

Closing this, PEP 426 never got accepted (although there are rumbling of working on it again) and I think that a placeholder for "when that is accepted, implement it" does not provide much value, we're unlikely to forget to implement the PEP after accepting it.

@dstufft dstufft closed this as completed Mar 22, 2017
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

No branches or pull requests

2 participants